calibre: 8.16.2 -> 9.4.0; python3.13 -> python3.14; fix build by Stebalien · Pull Request #494483 · NixOS/nixpkgs

Stebalien · 2026-02-26T20:47:20Z

calibre 9.0+ requires python3.14+.

This addresses the security issues #494339, #494340, #495148; But I'm not sure what the python3.14 policy is for nixos-stable.

Also fixes #489028 (update calibre).

Finally, this works around the build failure #420293 until the correct fix (#493988) passes through staging and lands on master.

Things done

Stebalien · 2026-02-26T20:52:03Z

Notes:

Last time this came up, I thought updating to python 3.14 was going to be tricky, but it turns out speechd was the only package that needed some massaging.
I tested the speech feature, and it seems to work. Calibre doesn't use the piper-tts python module, so there's no need to rebuild piper-tts for python3.14. In fact, piper-tts doesn't build for python3.14 because it depends on aws-sam-translator which doesn't build on python3.14.
This PR is affected by Build failure: calibre #493843 and won't build until qt6.qtbase: fix incorrect substitution in setupHook #493988 lands on master.

mdorman

This change seems straightforward and uncontroversial.

AchmadFathoni · 2026-02-28T02:18:32Z

Calibre 9.4 is out now

Stebalien · 2026-02-28T15:57:37Z

The security issues are piling up so I'm just going to work around the build failure as suggested by @wrvsrv in #493843 and mark this PR ready for review.

Stebalien · 2026-02-28T16:41:31Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 494483 --skip-package convertx
Commit: e18fec7eb7131823658e524cff0eb9ca5b404fbb

`x86_64-linux`

✅ 3 packages built:

calibre
calibre-no-speech
unbook

Stebalien · 2026-02-28T16:42:24Z

I skipped convertx because that requires building libreoffice (hydra failed during the last rebuild) and my poor laptop isn't up to the task.

sempiternal-aurora

Looks good to me, this basically is what my own changes to the derivation boil down to. Just waiting on a aarch64-linux build right now, though it may be awhile as my little m2 macbook air is trying to compile torch, which takes 30 minutes on the build servers.

sempiternal-aurora · 2026-03-02T07:50:53Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 494483
Commit: e18fec7eb7131823658e524cff0eb9ca5b404fbb

`aarch64-linux`

✅ 5 packages built:

calibre
calibre-no-speech
convertx
nixpkgs-manual
unbook

pkgs/by-name/ca/calibre/package.nix

calibre 9.0+ requires python3.14+.

This applies a workaround suggested by @wrvsrv. Unfortunately, the correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to pass through staging. fixes NixOS#493843

@mjoerg

Include version information in the debian patches so we re-fetch them every time we bump the version, ensuring the hashes remain correct. (suggested by @mjoerg)

Stebalien · 2026-03-02T19:41:10Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 494483
Commit: 41e3ede6c7c457067045254d9f2d97a2075496cc

`x86_64-linux`

✅ 4 packages built:

calibre
calibre-no-speech
convertx
unbook

Stebalien · 2026-03-03T19:23:35Z

Decisions:

Is updating to python3.14 ok here?
Is working around Build failure: calibre #493843 until qt6.qtbase: fix incorrect substitution in setupHook #493988 passes through staging ok?
Should this be backported to 25.11? It contains security fixes, but it's also a major version bump and it depends on python 3.14.

nixos-discourse · 2026-03-03T19:24:02Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6505

sempiternal-aurora · 2026-03-03T21:07:26Z

Decisions:

Is updating to python3.14 ok here?

Is working around Build failure: calibre #493843 until qt6.qtbase: fix incorrect substitution in setupHook #493988 passes through staging ok?

Should this be backported to 25.11? It contains security fixes, but it's also a major version bump and it depends on python 3.14.

My two cents:

I'm not sure about. I reckon it should be fine, everything builds right now and it gets a new version out, though I'm not aware of procedure around python versions either
I don't see a problem, as long as the change won't break the build when it does hit master and cause an immediate build failure that needs to be resolved, letting us just remove the fix when we next update.
I don't think it is appropriate, a major version bump, along with noted new features isn't stable, the interface is changing, and it isn't just patches and bug fixes. This is why I didn't backport the 8.16 update to staging, new ai features.

Stebalien · 2026-03-03T21:29:50Z

I don't see a problem, as long as the change won't break the build when it does hit master and cause an immediate build failure that needs to be resolved, letting us just remove the fix when we next update.

We should be fine there as the path to qmake isn't changing (the workaround here just correctly sets the QMAKE environment variable).

I don't think it is appropriate, a major version bump, along with noted new features isn't stable, the interface is changing, and it isn't just patches and bug fixes. This is why I didn't backport the 8.16 update to staging, new ai features.

Fair enough, but we'll need to backport patches to fix #494339, #494340, and #495148.

sempiternal-aurora · 2026-03-04T03:37:45Z

@Stebalien Happy to create the patch backport unless you particularly want too?

SuperSandro2000 · 2026-03-04T13:21:33Z

Python 3.14 is not very ready in 25.11 and it is a major update.

Stebalien · 2026-03-04T15:01:44Z

@SuperSandro2000 I think the idea is to backport the individual security patches:

#494339
#494340
#495148

And now:

#496127

Stebalien · 2026-03-04T15:02:02Z

@sempiternal-aurora please do so if you have the time.

edit: I see you already did #496499 ❤️

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Feb 26, 2026

Stebalien requested review from pSub and sempiternal-aurora February 26, 2026 20:53

mdorman approved these changes Feb 27, 2026

View reviewed changes

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 27, 2026

Stebalien force-pushed the steb/update-calibre branch from bbf3a15 to cab9f2d Compare February 28, 2026 15:30

Stebalien changed the title ~~calibre: 8.16.2 -> 9.3.1; python3.13 -> python3.14~~ calibre: 8.16.2 -> 9.4.0; python3.13 -> python3.14 Feb 28, 2026

Stebalien changed the title ~~calibre: 8.16.2 -> 9.4.0; python3.13 -> python3.14~~ calibre: 8.16.2 -> 9.4.0; python3.13 -> python3.14; fix build Feb 28, 2026

Stebalien marked this pull request as ready for review February 28, 2026 15:54

Stebalien added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 28, 2026

sempiternal-aurora approved these changes Mar 2, 2026

View reviewed changes

nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 2, 2026

mjoerg reviewed Mar 2, 2026

View reviewed changes

pkgs/by-name/ca/calibre/package.nix Outdated Show resolved Hide resolved

Stebalien added 2 commits March 2, 2026 06:56

calibre: 8.16.2 -> 9.4.0; python3.13 -> python3.14

6a0430d

calibre 9.0+ requires python3.14+.

calibre: fix build until NixOS#472656 lands on master

0431d32

This applies a workaround suggested by @wrvsrv. Unfortunately, the correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to pass through staging. fixes NixOS#493843

Stebalien force-pushed the steb/update-calibre branch from e18fec7 to 0431d32 Compare March 2, 2026 14:57

calibre: re-fetch patches on every version bump

41e3ede

Include version information in the debian patches so we re-fetch them every time we bump the version, ensuring the hashes remain correct. (suggested by @mjoerg)

SuperSandro2000 approved these changes Mar 4, 2026

View reviewed changes

SuperSandro2000 added this pull request to the merge queue Mar 4, 2026

nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Mar 4, 2026

Merged via the queue into NixOS:master with commit 16ad066 Mar 4, 2026
32 of 34 checks passed

Stebalien deleted the steb/update-calibre branch March 4, 2026 02:07

Uh oh!

Conversation

Stebalien commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

Stebalien commented Feb 26, 2026

Uh oh!

mdorman left a comment

Choose a reason for hiding this comment

Uh oh!

AchmadFathoni commented Feb 28, 2026

Uh oh!

Stebalien commented Feb 28, 2026

Uh oh!

Stebalien commented Feb 28, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

Stebalien commented Feb 28, 2026

Uh oh!

sempiternal-aurora left a comment

Choose a reason for hiding this comment

Uh oh!

sempiternal-aurora commented Mar 2, 2026

nixpkgs-review result

aarch64-linux

Uh oh!

Uh oh!

Stebalien commented Mar 2, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

Stebalien commented Mar 3, 2026

Uh oh!

nixos-discourse commented Mar 3, 2026

Uh oh!

sempiternal-aurora commented Mar 3, 2026

Uh oh!

Stebalien commented Mar 3, 2026

Uh oh!

Uh oh!

sempiternal-aurora commented Mar 4, 2026

Uh oh!

SuperSandro2000 commented Mar 4, 2026

Uh oh!

Stebalien commented Mar 4, 2026

Uh oh!

Stebalien commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Stebalien commented Feb 26, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`aarch64-linux`

`nixpkgs-review` result

`x86_64-linux`

Stebalien commented Mar 4, 2026 •

edited

Loading